-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add search bar functionality #27
Merged
Merged
+107
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a custom hook to debounce a value. Will be used in the search bar to avoid triggering an API request on every keystroke
Closed
martakam
previously approved these changes
Sep 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Also good to have debouncing on this immediately - fantastic you remembered this from the group meeting.
martakam
previously approved these changes
Sep 16, 2026
|
Fixed a merge conflict, but everything should be alright. Need a new PR review from someone that is not me and not Henrik |
johahor
approved these changes
Sep 17, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, worked perfect. Great work on the debounce.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a functional search bar for filtering books in the BookGrid. The search bar is connected to the query in
BookGridand also uses a debounce.Changes include:
SearchBarcomponentuseDebouncehook to delay the search query sent to the API, so it only updates once the user has stopped typing, instead of on every keystrokeBookGridNote: An empty search currently falls back to a hardcoded default query (
subject:fantasy)